Generate some ml type definitions #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
generate-type-defs
branch
from
e1bf0d2
to
a264fa7
Compare
sonmarcho
reviewed
Aug 12, 2024
sonmarcho
reviewed
Aug 12, 2024
|
I hadn't thought of the fact that doing this would allow to port the documentation from the Rust side to the OCaml side: this is extremely useful. The only minor change I would like to do is a better indentation of the multi-line comments (as you can see, having no indentation is a bit ugly). |
|
The other problem is that this causes many errors when building the ocaml doc, because the ocaml doc format doesn't like the markdown syntax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #215. This auto-generates a number of ml definitions from the rust ones. I've left the visitor definitions as-is; that feels incomplete, I hope to find a cleaner solution when more of the types are auto-generated.
Nice bonus: this copies the doc-comments present on the rust side.